zodiacsigns.js.org #2401
Merged
zodiacsigns.js.org #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DipanshKhandelwal
commented
Oct 9, 2018
DipanshKhandelwal
commented
- There is reasonable content on the page (see: my-zodiac-sign - website )
- I have read and accepted the Terms and Conditions
MattIPv4
requested changes
Oct 9, 2018
There was a problem hiding this comment.
Site has content, commit is valid.
CNAME is not present in gh-pages of https://github.com/DipanshKhandelwal/my-zodiac-sign/tree/gh-pages
|
@MattIPv4 Oh right thanks, I have added it now. |
|
I've already added your requested subdomain to JS.ORGs zonefile. But you have to move the |
|
@indus Done. I removed it by mistake in the last commit 😅. But now it's fine 👍 |
|
Welcome https://zodiacsigns.js.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.