Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for specifying other key when loading a "with" relation #66

Open
techniq opened this issue Mar 11, 2016 · 3 comments
Open

Comments

@techniq
Copy link
Member

techniq commented Mar 11, 2016

Need to create some tests for this change, which requires some new non-standard tables/relations to test against

@jmdobry
Copy link
Member

jmdobry commented Mar 11, 2016

Take note, the new adapter specification in 3.x accomplishes something similar but in a different fashion. It uses methods that the user can override in order to pick or otherwise transform the keys.

@techniq
Copy link
Member Author

techniq commented Mar 11, 2016

Awesome. I need to take a look at them.

On Thu, Mar 10, 2016, 11:58 PM Jason Dobry notifications@github.com wrote:

Take note, the new adapter specification in 3.x accomplishes something
similar but in a different fashion. It uses methods that the user can
override in order to pick or otherwise transform the keys.


Reply to this email directly or view it on GitHub
#66 (comment).

@jmdobry
Copy link
Member

jmdobry commented Mar 11, 2016

I've actually managed to extract a lot of common adapter functionality into a base Adapter class, which saves a lot of boilerplate. If you take a look at say js-data-mongodb v1 you'll see that it only has to provide a few MongoDB specifics, but it was full lifecycle hook, debug logging, and relation eager-loading support.

The base class also makes it much easier to keep adapters in sync as far as the adapter interface goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants