support NOMAD_CLIENT_CERT and NOMAD_CLIENT_KEY#96
Merged
jrxFive merged 2 commits intojrxFive:masterfrom Oct 9, 2019
Merged
Conversation
https://nomadproject.io/guides/security/securing-nomad.html When using Nomad in a secured fashion, allow the user to specify environment variables NOMAD_CLIENT_CERT and NOMAD_CLIENT_KEY to specify custom a cert and key. This behavior matches that of the official Nomad cli.
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=========================================
- Coverage 91.23% 91.1% -0.14%
=========================================
Files 26 26
Lines 1038 1034 -4
=========================================
- Hits 947 942 -5
- Misses 91 92 +1
Continue to review full report at Codecov.
|
jrxFive
reviewed
Oct 8, 2019
Owner
jrxFive
left a comment
jrxFive
left a comment
There was a problem hiding this comment.
Hey @erhlee-bird, thanks so much for the PR. Looks good! Only thing I can think of is updating the README.md about what environment variables are supported.
Collaborator
Author
|
Thanks for reviewing @jrxFive and the awesome library. |
jrxFive
approved these changes
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nomadproject.io/guides/security/securing-nomad.html
When using Nomad in a secured fashion, allow the user to specify
environment variables NOMAD_CLIENT_CERT and NOMAD_CLIENT_KEY to
specify custom a cert and key.
This behavior matches that of the official Nomad cli.