Adding __str__ method to improve errors readability#94
Merged
jrxFive merged 2 commits intojrxFive:masterfrom Oct 8, 2019
Merged
Adding __str__ method to improve errors readability#94jrxFive merged 2 commits intojrxFive:masterfrom
jrxFive merged 2 commits intojrxFive:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=========================================
- Coverage 91.23% 91.1% -0.14%
=========================================
Files 26 26
Lines 1038 1034 -4
=========================================
- Hits 947 942 -5
- Misses 91 92 +1
Continue to review full report at Codecov.
|
greut
reviewed
Sep 14, 2019
nomad/api/exceptions.py
Outdated
| def __init__(self, nomad_resp): | ||
| self.nomad_resp = nomad_resp | ||
|
|
||
| pass |
There was a problem hiding this comment.
pass is only required if you don't have a docstring.
Owner
|
Hey @SlipJ, thanks so much for the PR/improvement to the exception string dunder! |
jrxFive
approved these changes
Oct 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving the custom errors readability so that it will also include the response that caused it.
Also removing the inherited init method.