Skip to content

response will always be None, pass in the exception#90

Merged
erhlee-bird merged 1 commit intojrxFive:masterfrom
cloudbuy:fix-requests-error
Jan 31, 2020
Merged

response will always be None, pass in the exception#90
erhlee-bird merged 1 commit intojrxFive:masterfrom
cloudbuy:fix-requests-error

Conversation

@damoxc
Copy link
Contributor

@damoxc damoxc commented Jan 24, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          26       26           
  Lines        1038     1038           
=======================================
  Hits          947      947           
  Misses         91       91
Impacted Files Coverage Δ
nomad/api/base.py 97.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03557e3...e10abe4. Read the comment docs.

Copy link
Collaborator

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants