-
Notifications
You must be signed in to change notification settings - Fork 77
Support stopping an allocation #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 78.89% 78.85% -0.05%
==========================================
Files 26 26
Lines 1199 1201 +2
==========================================
+ Hits 946 947 +1
- Misses 253 254 +1
Continue to review full report at Codecov.
|
|
I downloaded your branch and confirmed that the surface functionality is as I expect. I additionally ran the tests locally and aside from a few potentially flaky tests, things look good. |
erhlee-bird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I made one comment on a stylistic change in the tests file that I think would better fit the existing code.
erhlee-bird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you so much for your contribution.
I noticed stopping an allocation was not yet supported. Hereby.
Thanks for your work!