Skip to content

remove py34 support#101

Merged
erhlee-bird merged 1 commit intojrxFive:masterfrom
resmo:enh/remove-py34
Feb 3, 2020
Merged

remove py34 support#101
erhlee-bird merged 1 commit intojrxFive:masterfrom
resmo:enh/remove-py34

Conversation

@resmo
Copy link
Collaborator

@resmo resmo commented Feb 3, 2020

Fixes #100

I didn't find anything related to py34 in the code, just CI and setup.py.

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #101   +/-   ##
======================================
  Coverage    91.1%   91.1%           
======================================
  Files          26      26           
  Lines        1034    1034           
======================================
  Hits          942     942           
  Misses         92      92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa997a...14a9e59. Read the comment docs.

@erhlee-bird
Copy link
Collaborator

LGTM, we should make another issue mirroring this to remove py27 as well.

@erhlee-bird erhlee-bird merged commit b6899d8 into jrxFive:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove py34 support

3 participants