Skip to content

Conversation

@prathamesh-sonpatki
Copy link
Contributor

No description provided.

@BanzaiMan
Copy link
Member

Please remove .rspec from this PR. Thank you.

@prathamesh-sonpatki
Copy link
Contributor Author

@BanzaiMan Done

@BanzaiMan
Copy link
Member

@komax Please review the code.

enebo added a commit that referenced this pull request Oct 1, 2013
Added spec_helper and used correct paths in specs

Looks good.  Just some fallout from renaming from jruby-visualizer to jruby_visualizer in specs.   spec-helper changes are also ok.   @komax is moving right now and cannot review.
@enebo enebo merged commit b45ff60 into jruby:master Oct 1, 2013
@komax
Copy link
Member

komax commented Oct 1, 2013

Thank you for merging, @enebo. Yeah, I am currently quite busy, to have my first work day for my PhD and two moves in the Netherlands as well.

@prathamesh-sonpatki very nice of you to update the specs! I forgot to rename them with the new name scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants