Custom logging broken in 1.1.3

[matthauck]

I made a comment on a commit I think to be broken but thought I'd include it here too.

I think this commit breaks setting up custom logs. I am using Log4j and set up my logger instances in config/environments/*.rb. This worked just fine on 1.0.10, but upgrading to 1.1.3 broke my logging. By the end of Application.initialize! my loggers had been reset back. I am guessing it was this commit that did it.

I suggest it should be reworded to use config.logger ||= ... so as not to overwrite others customizations.

[kares]

the initializer is supposed to run before your environment/.rb* files thus setting a custom logger say in development.rb :

 config.logger = Logger.new("#{Rails.root}/log/custom.log")

should override the default setting, anyway since there's no default value for config.logger adding ||= won't hurt.
but for the record since I tested this previously on 3.1 and it worked what Rails are you running, what env did you observe this in ?

[matthauck]

I'm not sure why, but it appears to run afterward for me. It is getting reset back to Rails "Logger" class somewhere after my development.rb, and before initialize! is finished.

I'm running rails 3.0.10 on jruby 1.6.5.1 (--1.9), observed this in production environment in servlet context (I think it might have worked okay in webrick, but don't remember clearly now).

[kares]

Matt, you're right the order seems different in 3.0.x thanks !
You probably can workaroud (until 1.1.4) this by setting Rails.logger in a config/initializers/custom_logger.rb
Although you still might end up with default loggers in ActiveRecord::Base.logger etc.

[matthauck]

Sweet, thanks.