[deps] upgrade BC to latest 1.74 #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Chad, will take a look - there's a couple of items that I will need to find free time to work on before pushing a release. Reading the CVE I do not see JOSSL affected by this, hopefully I understood correctly and this can be tagged out for JRuby. |
|
@kares Yeah, I don't think relevant to JRuby users either, but you know those noisy CVE scanners. 😅 Currently the CVE hasn't been disclosed via MITRE/NIST (still RESERVED here) so it's not yet linked to bouncycastle CPE but when it is I guess folks may start complaining about transitive noise via jruby-complete and friends. As a side note, I see there are no automated tests run against a JRuby 9.4.x release currently - not sure if that is of concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps BouncyCastle to latest patched version.
Not sure if jruby-openssl uses the vulnerable LDAP stuff mentioned in CVE-2023-33201 however this is probably good to reduce noise.
It also has the positive side effect of reducing uber-jar size, as "The now defunct PQC SIKE algorithm has been removed" which seems to reduce by ~3MB.
https://www.bouncycastle.org/releasenotes.html#r1rv74