Skip to content

Update basic.rb #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Update basic.rb #15

merged 1 commit into from
Apr 13, 2020

Conversation

monkstone
Copy link
Contributor

Since JRuby-9.2.11.xx need to explicitly import jruby, import javadoesn't work anymore (correct me if I'm wrong)

Since JRuby-9.2.11.xx need to explicitly import `jruby`, import `java`doesn't work anymore (correct me if I'm wrong)
@headius
Copy link
Member

headius commented Apr 13, 2020

@monkstone The 'java' import is fine, but it is required at boot by JRuby since 9.0 since we use Java integration for some Ruby internals.

The jruby require is necessary only for "internal" features of the JRuby module, like parsing or compiling code, accessing the raw Java object for a given Ruby object, or as in this case, accessing the current JRuby runtime with JRuby.runtime.

I don't see us ever changing the fact that java is loaded at boot, so this change seems appropriate.

@headius headius merged commit e65264e into jruby:master Apr 13, 2020
@monkstone monkstone deleted the patch-1 branch April 13, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants