Jruby 9.2.7.0 #49
Merged
Jruby 9.2.7.0 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think `$(< VERSION)` is a bash-ism, at least `./update.sh` wouldn't run for me unless I changed the shebang.
|
Thanks! I can do this tomorrow, but also feel free to open a pr over there :) ❤️ |
|
Thanks! If you can do it tomorrow, that's great, otherwise I'll look into creating that PR 👍 |
|
Looked into what's need in the previous bump and looks easy enough. I'll do it! 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48.
Includes two other related changes. At the beginning I was getting a 404 when running
./update.sh. I initially thought the s3 urls no longer worked because of rbenv/ruby-build#1148. But in the end the problem was that the scripts used the$(< VERSION)construct which doesn't work in my default shell (dash).