With our powers combined

[jrsconfitto]

This PR vendors the SublimeText/PowerShell repository to generate the Atom grammar cson file for this Atom language grammar. This is as per discussion in #35.

Vendoring this work seems reasonable considering @vors qualifications 😉 and (at this moment) github's linguist vendors this same repository for their own code highlighting.

Right now, i've submoduled that repository and wrote a quick script that will translate it's plist tmLanguage file to cson.

There's probably a few more things i should pin down before closing this out:

• Fix the tests (they're almost all broken now)
• Make sure i get rid of the earlier licensing
• Make sure the license references the newly vendored repository's license

[jrsconfitto]

Looks good so far even though CI is 😿

[vors]

👍 👍 👍
Btw, your test suite in coffee script looks quite impressive. We should incorporate it in SublimeText/PowerShell.

Please, join our discussion about future release SublimeText/PowerShell#78

[jrsconfitto]

Here's some failing tests i'm noticing that i suspect may need updating in the parent grammar.

Update: i'm skipping these tests while waiting on their issues.

• workflow and sequence don't pass their tests, but i don't know if they should? This article describes how to use them, but i'm not sure if they're standard to the language or an add-on or what?
• Bitwise operators -sh and -shl aren't given the scope of keyword.operator.bitwise.powershell (about_Comparison_Operators reference)

[jrsconfitto]

Thanks for adding that issue! i was planning on it once i was sure it was not a problem with my stuff.

[jrsconfitto]

i've just pushed a ton of commits... mind reviewing the test failures as you can @vors?

[jrsconfitto]

They are built in language since PS v3. You can treat workflow like a function and sequence like a process {...} in the function.

Those aren't issues in your repo too? My tests respond with:

(Sorry about the pic... atom's spec window doesn't copy/paste that for me!)

[jrsconfitto]

More things i'm not sure what to do with:

• --%, the "stop parsing char doesn't seem to be tokenized correctly. Update added issue to Add stop parsing symbol --% to the grammar SublimeText/PowerShell#104

  From about_escape_characters:

  In a call to another program, instead of using escape characters to prevent Windows PowerShell from misinterpreting program arguments, you can use the stop-parsing symbol (--%). The stop-parsing symbol is introduced in Windows PowerShell 3.0.

[jrsconfitto]

• $$ isn't tokenizing, i think it's supposed to. Update: part of the automatic variables issue in Put all automatic variables under one roof? SublimeText/PowerShell#103.

[vors]

wow, you are really dig into the spec. :) I will take a close look to test failures later today.

[jrsconfitto]

I have to because I never use any of that stuff! Also, a lot of those tests
were contributed by people that do use them, so I didn't do any of the
original work on them :)

If you want I don't mind opening issues, as long as you're ok with me
sending a few that may be my fault, not the Sublime/powershell repo's.
On Fri, Feb 27, 2015 at 2:16 PM Sergei Vorobev notifications@github.com
wrote:

wow, you are really dig into the spec. :) I will take a close look to test
failures later today.

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[vors]

oh, please do!

[jrsconfitto]

Trying to weigh how much i want to dig into the original repo! We'll see.

[jrsconfitto]

For now, i'm going to put notes in the code to skip the failing tests and push this through as a new major version. i think this stuff with its few failures is still an improvement from the current version.

[jrsconfitto]

Best way to pass tests? SKIP 'EM!

Waiting on this to pass ci, then i'll pull in these changes and publish a new major version from there 😄

[vors]

workflow is the same as function in our current grammar https://github.com/SublimeText/PowerShell/blob/master/Support/PowershellSyntax.tmLanguage#L525 for sequence I opened SublimeText/PowerShell#105

[vors]

👏