Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated ffmpeg-4.2 libs to newest versions #209

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tamara-schmitz
Copy link

I updated most of the libraries built from source in the alpine-4.2 image.
This involved changing version numbers, updating sha256sums, replacing URLs and adjusting build commands.
I have built the alpine image on my local machine.

I've made this PR to let you know that I'm working on this. I do intend to port this patch over to other images with the different OS base. But I would appreciate help on this.

@jrottenberg
Copy link
Owner

Oh that's great thank you, but can you make the change inside the template folder, so all variants benefits from them ?

@tamara-schmitz
Copy link
Author

tamara-schmitz commented Jan 11, 2020

what sorcery is this xD? templates? sure can do.
so what do would i need to run after i updated the templates?

EDIT: answer to myself. run ./update.py

@tamara-schmitz
Copy link
Author

git closed the PR after i reset the commit

this involved updating version numbers, changing some download URLs,
matching the respective sha256sums and adjusting build command chains.
@tamara-schmitz
Copy link
Author

tamara-schmitz commented Jan 11, 2020

while watching the checks running the following occured:

centos builds "completed" earlier than expected and reported success despite the non-zero return during the x264 compilation step. may be a bug with the build system. after the build error it stopped compiling the other libraries.
See for more: https://dev.azure.com/video-tools/ffmpeg/_build/results?buildId=207&view=logs&j=4b231adf-81ae-59a4-de69-1d5fb07de66a&t=456bf2ef-07d6-5c05-364c-4fc233413fe2&l=1081

The issue for the centos version is that the latest x264-stable requires version 2.13 of nasm while the current centos:7 base only provides nasm version 2.10.

@hvindin
Copy link
Contributor

hvindin commented Jan 30, 2020

If you were to rebase this and build it again the centos problem would likely be resolved. The base image for the centos containers is centos:8 which has cmake 3 as its packaged cmake version.

Zennoe added 3 commits February 4, 2020 16:16
this involved updating version numbers, changing some download URLs,
matching the respective sha256sums and adjusting build command chains.
@tamara-schmitz
Copy link
Author

tamara-schmitz commented Feb 4, 2020

welp libass doesnt build on CentOS...
configure: error: Package requirements (fribidi >= 0.19.0) were not met:.

will investigate this further and maybe even downgrade libass.

EDIT: a short Google Search revealed that fribidi is in fact available for CentOS and only needs to be added to the CentOS template. Will do so in a new commit.

@tamara-schmitz
Copy link
Author

tamara-schmitz commented Feb 4, 2020

And with the new dependency, CentOS's package manager now tries to install a package called epel-release which adds a new repo. But when it tries to update its DB from that repo it fails. Just whyyy....

Installed:
  epel-release-8-5.el8.noarch                                                   

Complete!
CentOS-8 - PowerTools                           8.9 MB/s | 2.0 MB     00:00    
Extra Packages for Enterprise Linux 8 - x86_64  376  B/s | 5.3 kB     00:14    
Failed to download metadata for repo 'epel'
Error: Failed to download metadata for repo 'epel'

But hey it only happened in the 4_2 centos build. Hopefully that's just a random hiccup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants