Feature: Improved support for standard tmux sessions #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented SessionType::Standard for existing tmux sessions - Implemented SessionContainer and Session listing functionality for Tmux struct - In main: Defined default command behavior (read: "tms") to output both git repos and existing tmux sessions
- Combines two HashMap<String, Session> into one, with keys being a set of unique session names - Tmux.create_sessions now gives all the the sessions from git and all the sessions from tmux. (Sessions from git should probably be moved to a different class)
- Introduce create_repo_sessions for repository session handling - Add find_tmux_sessions for retrieving tmux sessions - Merge both into create_all_sessions for a clear distribution of responsibilities
- Moved session tests to seperate file.
- Improved readability and efficiency - Renamed switch_to_normal_session() to switch_to_standard_session for consistency
- Readability - Logic
open_session_command now uses create_all_sessions instead of create_repo_sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #153
Enhances usefulness of the tms command and reduces reliance on standard tmux commands for many.
Existing tmux sessions are included in the fzf of standard commands such as
tms switchand the defaulttms(noargs). This makes aImplements new enum:
SessionType(Standard(PathBuf)). For tmux sessions not created from a git repo or a bookmark.Instead of
create_sessions()for getting sessions from git and bookmarks we now havecreate_repo_sessions()and additionallycreate_all_sessions()which includes Standard Tmux sessions in the resulting SessionContainer.Should this feature be enabled by default (i.e., not configurable), or should it be activated via a flag (e.g.
--include-standard-sessions)? If configurable, how should we resolve the conflict with--switch-filter-unknown, which currently applies only to tms switch?