Skip to content

Commit

Permalink
Fix deprecated uses of Redis#pipelined
Browse files Browse the repository at this point in the history
Context: redis/redis-rb#1059

The following is deprecated
```ruby
redis.pipelined do
  redis.get(key)
end
```

And should be rewritten as:
```ruby
redis.pipelined do |pipeline|
  pipeline.get(key)
end
```

Functionally it makes no difference.
  • Loading branch information
byroot authored and marcelolx committed Jan 28, 2022
1 parent 7302d77 commit bc2eaf3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/sidekiq-scheduler/redis_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,9 @@ def self.clean_schedules_changed
def self.register_job_instance(job_name, time)
job_key = pushed_job_key(job_name)
registered, _ = Sidekiq.redis do |r|
r.pipelined do
r.zadd(job_key, time.to_i, time.to_i)
r.expire(job_key, REGISTERED_JOBS_THRESHOLD_IN_SECONDS)
r.pipelined do |pipeline|
pipeline.zadd(job_key, time.to_i, time.to_i)
pipeline.expire(job_key, REGISTERED_JOBS_THRESHOLD_IN_SECONDS)
end
end

Expand Down

0 comments on commit bc2eaf3

Please sign in to comment.