Allow multiple instances of editor #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makkynz
force-pushed
the
hotfix/allow-multiple-instances
branch
from
48a9330 to
26831ae
Compare
… style change (e.g bold, list, italics, etc) on one instance was also updating the others. This fix generates a unique id for each instance that the update event checks to ensure only the correct instance is actually updated
makkynz
force-pushed
the
hotfix/allow-multiple-instances
branch
from
26831ae to
1dd4a6c
Compare
jrm2k6
requested changes
May 16, 2017
src/MarkdownEditor.js
Outdated
| @@ -105,6 +107,7 @@ var MarkdownEditor = React.createClass({ | |||
| }, | |||
|
|
|||
| updateText: function(text, selection, actionType) { | |||
| debugger; | |||
There was a problem hiding this comment.
Please, remove the debugger statement.
|
@jrm2k6 unit test will come shortly |
makkynz
force-pushed
the
hotfix/allow-multiple-instances
branch
from
3b93359 to
2b49212
Compare
|
@makkynz Thanks a lot! Approved and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve issue where when multiple instances of the editor exists, a style change (e.g bold, list, italics, etc) on one instance was also updating the other instances. This fix generates a unique id for each instance that the update event checks to ensure only the correct instance is actually updated