ADD_PYTHON_UNIT_TEST: allow multiple paths in argn #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple paths can be set in PYTHONPATH, but they have to be joined by
`os.pathsep`(":" on unix, ";" on windows)
https://docs.python.org/3/using/cmdline.html#envvar-PYTHONPATH
This commit fix the concatenation with any pre-existing environment
variables, and allows to set several folders (relative to the project
build tree) inside this PYTHONPATH.
eg. if you build a module in src/ and a test module in tests/, you can
import them both in a test with:
ADD_PYTHON_UNIT_TEST("test-python" "tests/main.py" "src" "tests")
jcarpent
reviewed
Sep 30, 2019
jcarpent
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Multiple paths can be set in PYTHONPATH, but they have to be joined by
os.pathsep,, which is:on unix, and;on windows (ref).This PR fix the concatenation with any pre-existing environment variables, and allows to set several folders (relative to the project build tree) inside this PYTHONPATH.
eg. if you build a module in
src/and a test module intests/, you can import them both in a test with:ADD_PYTHON_UNIT_TEST("test-python" "tests/main.py" "src" "tests")