-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Student Model to User Model #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the seeder to port Students over to the Users table. Updated the User model.
- Replaced parameter type of Student with User now that a student is a user. - Removed students from the auth config. - Created migration to add user_id column to the prompt_questions table. - Updated login and logout routes.
…need it. - Updated the StudentController and StudentRequest. - Updated the StudentPolicy. - Fixed the motivational message.
Updated the HOME and STUDENT routes in the RouteServiceProvider. Refactored the student routes to user routes and made necessary changes elsewhere.
…tal and vise versa.
- Removed the student resource from nova. - Updated the User Policy to allow a user to update their own data. - Added a route for students to be able to update their data. - Removed Student/Login.vue page as it's no longer needed. - Timezone is automatically filled in when creating a student now. - Added and fixed some tests. - Other small improvements.
Closed
justinwerner
requested changes
Jan 20, 2024
justinwerner
requested changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looking good. Just a couple more comments and a couple questions.
- Implemented the isStudent method. - Updated the UserPolicy so that a parent or a student can view, update, or delete.
justinwerner
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Student Model to the User Model in order to simplify things and allow for impersonation. Reference the commit messages for more details on what was changed. Resolves #33