Skip to content

Fix invalid error_messages on Regexfield (testapp customer/phonenumber) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: releases/1.7
Choose a base branch
from
Open

Fix invalid error_messages on Regexfield (testapp customer/phonenumber) #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions formset/boundfield.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,13 @@ def _get_client_messages(self):
client_messages['type_mismatch'] = client_messages['pattern_mismatch'] = server_messages['invalid']
elif 'invalid_choice' in server_messages:
client_messages['type_mismatch'] = server_messages['invalid_choice']
if 'bound_ordering' in server_messages:
client_messages['custom_error'] = server_messages['bound_ordering']
else:
for validator in self.field.validators:
validator_code = getattr(validator, 'code', None)
if validator_code == 'invalid':
client_messages['type_mismatch'] = client_messages['pattern_mismatch'] = validator.message
if 'bound_ordering' in server_messages:
client_messages['custom_error'] = server_messages['bound_ordering']
if getattr(self.field, 'max_length', None) is not None:
data = {'max_length': self.field.max_length}
max_length_message = _("Ensure this value has at most %(max_length)s characters.")
Expand Down