Exclude testapp submodules from built packages #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controls in `MANIFEST.in` are unfortunately neither necessary nor sufficient to control the inclusion of files from the 'testapp' directory in wheels built from the original source. Those are instead controlled by the packages listed in `setup.py`, as found by `find_packages`. It is unclear to me why `find_packages` requires explicitly excluding both 'testapp' and 'testapp*' (either spelling on its own isn't sufficient to exclude both files in the 'testapp' folder as well as those within subfolders), however from testing this combination has the desired effect. In theory this commit could remove the exclusion from `MANIFEST.in`, allowing the test files to be included in the source distribution now that they are fully excluded from the installed files, however it is the maintainer's preference that the files also be completely excluded from the source distribution too, so that is left unchanged. Tested by manually installing locally built source and wheel distribution packages and verifying what files were included within 'site-pacakges'. Fixes jrief#359
jrief
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controls in
MANIFEST.inare unfortunately neither necessary nor sufficient to control the inclusion of files from thetestappdirectory in wheels built from the original source. Those are instead controlled by the packages listed insetup.py, as found byfind_packages.It is unclear to me why
find_packagesrequires explicitly excluding both'testapp'and'testapp*'(either spelling on its own isn't sufficient to exclude both files in thetestappfolder as well as those within subfolders), however from testing this combination has the desired effect.Tested by manually installing locally built source and wheel distribution packages and verifying what files were included within
site-pacakges.Fixes #359