node 0.10 compatibility #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add it also in Travis list of versions? |
| @@ -45,7 +45,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "grunt": "^1.0.1", | |||
| "grunt-eslint": "^19.0.0" | |||
| "grunt-eslint": "^18.0.0" | |||
There was a problem hiding this comment.
Why going back one version?
There was a problem hiding this comment.
The eslint task is not ES5 compatible in the 19.0 and it does not work in node 0.10.
If the eslint task could be skipped when running on older node versions this wouldn't be a problem, but I think this is the easiest solution.
There was a problem hiding this comment.
This commit is the problem:
sindresorhus/grunt-eslint@d0ff942
|
Thank you for your effort! |
|
your welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task runs in node 0.10 after replacing const expressions to var.