Fix clippy warnings and tests

src/fmt.rs

@@ -30,7 +30,7 @@ where
 	type Context = T::Context;
 
 	fn fmt(&self, f: &mut std::fmt::Formatter<'_>, context: Self::Context) -> std::fmt::Result {
-		(&**self).fmt(f, context)
+		(**self).fmt(f, context)
 	}
 }
 

src/runtime/lib/typecheck.rs

@@ -36,7 +36,7 @@ impl Typecheck {
 		match context.args() {
 			[ value, Value::String(expected) ] => {
 				let expected_type = Type
-					::parse(&expected)
+					::parse(expected)
 					.ok_or_else(
 						|| Panic::value_error(
 							Value::String(expected.copy()),

src/runtime/mod.rs

@@ -12,7 +12,7 @@ pub mod value;
 #[cfg(test)]
 mod tests;
 
-use std::{collections::HashMap, ops::Deref};
+use std::collections::HashMap;
 
 use crate::symbol::{self, Symbol};
 use super::semantic::program;
@@ -454,7 +454,6 @@ impl Runtime {
 							),
 
 							(Value::Array(ref array), Value::Int(ix)) => array
-								.deref()
 								.set(ix, value)
 								.map_err(|_| Panic::index_out_of_bounds(Value::Int(ix), pos.into()))?,
 

src/runtime/value/array.rs

@@ -114,7 +114,7 @@ impl Array {
 
 
 // GcCell does not implement Eq because `borrow` might panic.
-#[allow(clippy::derive_hash_xor_eq)]
+#[allow(clippy::derived_hash_with_manual_eq)]
 impl Hash for Array {
 	fn hash<H: Hasher>(&self, state: &mut H) {
 		self.borrow().hash(state)

src/runtime/value/dict.rs

@@ -118,7 +118,7 @@ impl Ord for Dict {
 
 /// We need Hash in order to be able to store dicts as keys in other dicts.
 // GcCell does not implement Eq because `borrow` might panic.
-#[allow(clippy::derive_hash_xor_eq)]
+#[allow(clippy::derived_hash_with_manual_eq)]
 impl Hash for Dict {
 	fn hash<H: Hasher>(&self, state: &mut H) {
 		// This is very expensive, but there is no better way to correctly compare.

src/runtime/value/function.rs

@@ -251,7 +251,7 @@ impl Eq for RustFun { }
 
 impl PartialOrd for RustFun {
 	fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-		self.name().partial_cmp(other.name())
+		Some(self.cmp(other))
 	}
 }
 

src/semantic/mod.rs

@@ -32,7 +32,7 @@ use program::{
 	RedirectionTarget,
 	Statement,
 };
-pub use error::{Error, ErrorKind, Errors, ErrorsDisplayContext};
+pub use error::{Error, Errors, ErrorsDisplayContext};
 
 
 /// Static semantic analyzer.
@@ -486,6 +486,7 @@ impl<'a> Analyzer<'a> {
 			ast::Literal::Function { params, body } => {
 				let mut analyzer = self.enter_frame();
 
+				#[allow(clippy::manual_try_fold)] // We don't want to short circuit here.
 				let params_result = params
 					.iter()
 					.fold(

src/syntax/lexer/automata/argument.rs

@@ -274,7 +274,7 @@ where
 				if !c.is_word_start() {
 					self.error = true;
 				}
-				if self.braces == None {
+				if self.braces.is_none() {
 					self.braces = Some(false);
 				}
 

src/syntax/lexer/tests.rs

@@ -25,7 +25,7 @@ macro_rules! assert_symbol {
 /// Check that TokenKind is not too big, because it gets moved around a lot.
 #[test]
 fn test_token_kind_size() {
-	assert_eq!(std::mem::size_of::<TokenKind>(), 32);
+	assert!(std::mem::size_of::<TokenKind>() <= 32);
 }
 
 

src/syntax/parser/command.rs

@@ -97,7 +97,7 @@ where
 				&self.token,
 				// The current token is a single unquoted number
 				Some(Token { kind: TokenKind::Argument(parts), .. })
-					if matches!(parts.as_ref(), &[ref part] if part.is_unquoted_number())
+					if matches!(parts.as_ref(), [part] if part.is_unquoted_number())
 					// And the next token is a redirection operator.
 					&& matches!(
 						self.cursor.peek(),

src/syntax/parser/mod.rs

@@ -671,7 +671,7 @@ where
 					.with_sync(sync::Strategy::keyword(Keyword::End))?;
 
 				Ok(ast::Expr::If {
-					condition: condition.into(),
+					condition,
 					then,
 					otherwise,
 					pos,

src/term/color.rs

@@ -3,7 +3,7 @@ use std::{
 	fmt::{self, Debug, Display},
 };
 
-pub use termion::color::{Black, Blue, Green, Red, Yellow};
+pub use termion::color::{Blue, Green, Red, Yellow};
 
 
 thread_local! {