Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegates features list request to rollout #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pote
Copy link

@pote pote commented Apr 14, 2014

#features was returning an empty array on my app - I'm setting it up from scratch with the latest version of rollout.

I noticed $rollout does actually have a shortcut for its features, so I'm delegating the wrapper's call to rollout instead of relying on its own separate implementation, fixes my problem. :)

@kyleries
Copy link
Collaborator

@pote - Thanks for the PR! We're working on addressing this discrepancy currently but will likely not go down the path of using ActiveSupport#delegate for the same reasons mentioned here #3 . Let me know if you disagree, otherwise I'll be closing this issue. Glad it worked for you though. 😉

If you'd like to submit an alternative, feel free, otherwise #25 is looking promising if you'd like to experiment with, or weigh in on, that solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants