Fixes #8714: turn on "unused": true in JSHint #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -425,7 +425,7 @@ function abort( msg ) { | |||
| function walk( methods ) { | |||
| var method = methods.shift(); | |||
|
|
|||
| function next( error ) { | |||
| function next( ) { | |||
There was a problem hiding this comment.
This left some whitespace.
There was a problem hiding this comment.
K. I'll fix all the whitespace in the AM. Just leave the comments.
| @@ -1114,7 +1111,7 @@ function standardSpeed( speed ) { | |||
| } | |||
|
|
|||
| $.fn.extend({ | |||
| effect: function( effect, options, speed, callback ) { | |||
There was a problem hiding this comment.
Please keep these args around (even if commented)
kborchers
pushed a commit
that referenced
this pull request
Nov 1, 2012
…m codebase. - Closes gh-788 Squashed commit of the following: commit 7f19f92 Author: Mike Sherov <mike.sherov@gmail.com> Date: Tue Oct 23 10:34:28 2012 -0400 put back in fake args for signatures that we want to keep commit 257505a Author: Mike Sherov <mike.sherov@gmail.com> Date: Tue Oct 23 08:10:20 2012 -0400 changes per @scott_gonzalez commit 1272548 Author: Mike Sherov <mike.sherov@gmail.com> Date: Mon Oct 22 22:54:05 2012 -0400 clean up unused vars in ui directory commit 563595e Author: Mike Sherov <mike.sherov@gmail.com> Date: Mon Oct 22 22:37:42 2012 -0400 clean up unused vars in grunt and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of files changed, but all of the changes are minor and benign. All tests still pass. Please let me know if I need to make any changes. Thanks!