Resizeable: avoid braking the size of an image#2379
Open
aleen42 wants to merge 1 commit intojquery:mainfrom
Open
Resizeable: avoid braking the size of an image#2379aleen42 wants to merge 1 commit intojquery:mainfrom
aleen42 wants to merge 1 commit intojquery:mainfrom
Conversation
Member
|
Thanks for the report. Does the issue you describe exist when jQuery UI 1.12.1 is used or only with jQuery UI 1.13.0 or newer? |
Member
|
Also, please provide a runnable test case on a platform like JS Bin. |
Member
|
I also didn't notice it was a PR. Changes like that also need tests ensuring the issue is really fixed. |
mgol
requested changes
Jan 29, 2026
Member
mgol
left a comment
There was a problem hiding this comment.
Requires tests. Ideally, please also prepare a test case on JS Bin or similar.
Author
|
Thanks for reviewing, I will make it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an image has both
marginandpadding, there are two problems:marginhas set to the wrapper, but the image's one is not clear when initialisingouterWidthor the height withouterHeight.