Skip to content

Fix 1144 (Fix and Re-enable some unit tests on dialog, tooltip, and draggable) #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix 1144 (Fix and Re-enable some unit tests on dialog, tooltip, and draggable) #1173

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
432ea96
Fix/enable a couple of unit tests: dialog, tooltip, draggable.
bdowling Dec 2, 2013
91adb35
Gruntfile.js config for viewportSize missed from last commit
bdowling Dec 2, 2013
f6a5cfe
Tests: Fixed a couple of tests that failed due to :focus
bdowling Jan 17, 2014
9e151c5
Formatting: Fixed tabbing in Gruntfile
bdowling Jan 17, 2014
1020e93
Spacing: after paren
bdowling Jan 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Gruntfile.js config for viewportSize missed from last commit 
Note, this depends on the new phantomjs/main.js in the not yet merged feature
in gruntjs/grunt-lib-phantomjs#21
  • Loading branch information
@bdowling
bdowling committed Jan 17, 2014
commit 91adb3508dab3f77dfe5c4f1794e0f8e884a30d5
7 changes: 6 additions & 1 deletion Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,12 @@ grunt.initConfig({
files: expandFiles( "tests/unit/**/*.html" ).filter(function( file ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the indent here and the following lines?

// TODO except for all|index|test, try to include more as we go
return !( /(all|index|test)\.html$/ ).test( file );
})
}),
options: {
page : {
viewportSize : { width: 700, height: 500 }
}
}
},
jshint: {
options: {
Expand Down