Add tooltipAccessor prop to calendar to disable tooltip if needed #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Jan 23, 2018
src/DayColumn.js
Outdated
| title: | ||
| (typeof label === 'string' ? label + ': ' : '') + tooltip, | ||
| } | ||
| : {})} |
There was a problem hiding this comment.
lets make this a bit less ugly please :P i'd just set title to undefined in the one case that will be fine
jquense
reviewed
Jan 23, 2018
src/EventCell.js
Outdated
| @@ -75,7 +78,7 @@ class EventCell extends React.Component { | |||
| onClick={e => onSelect(event, e)} | |||
| onDoubleClick={e => onDoubleClick(event, e)} | |||
| > | |||
| <div className="rbc-event-content" title={title}> | |||
| <div className="rbc-event-content" {...tooltip ? { title: tooltip } : {}}> | |||
jquense
approved these changes
Feb 5, 2018
|
thanks! |
|
Hey, can you please let me know the ETA... |
|
Can you please tell me how to off the built it Tooltip? I already tried many times but I still failed. Thanks and Sorry, newbie here |
|
I already added toolTipAccessor but what is my next move? Where can I defined tooltip as undefined or null? |
|
@RusselFourteen It works like the others accessors. Assign a function who returns NULL to the tooltipAccessor and it will be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a "tooltipAccessor" prop for the tooltip instead of the "titleAccessor" prop. Can show a tooltip different from the title, or not display it at all if the accessor returns null.
Fixes #226, #470