Fixup resource PR #671
Merged
Fixup resource PR #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've updated React to v16 here. Did you test the app after that? Because it's not working for me anymore after this commit. Perhaps React v16 conflicts with markdown-jsx-loader v2 |
This was referenced Jan 8, 2018
|
I just tested this on master, and although it works for month an week view, it doesn't work for the Day and Agenda views. No events are shown for the Day and Agenda views. |
|
I know what the problem is. It was from this update (#638). The inRange function doesn't work when the start and end dates are the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.