Switch to using importlib.metadata #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, this all seems sensible. I will have this PR merged for next release with #61 I was just working with pkg_resources in my day job so I appreciate you teaching me about this importlib.metadata :) |
jquast
previously approved these changes
Jul 22, 2022
hugovk
suggested changes
Oct 13, 2022
pkg_resources is a little heavyweight, and has some rather glaring shortcomings for checking the metadata of an install Python package. importlib.metadata is contained in the standard library (as of 3.8), and provides a much nicer interface. Switch to using it, falling back to importlib_metadata if the Python version is too old.
s-t-e-v-e-n-k
force-pushed
the
remove-pkg_resources
branch
from
703593c to
d38b100
Compare
hugovk
reviewed
Oct 14, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
jquast
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources is a little heavyweight, and has some rather glaring
shortcomings for checking the metadata of an install Python package.
importlib.metadata is contained in the standard library (as of 3.8), and
provides a much nicer interface. Switch to using it, falling back to
importlib_metadata if the Python version is too old.