Skip to content

Conversation

@avylove
Copy link
Collaborator

@avylove avylove commented Sep 20, 2021

Blocker for releasing 1.19.0
PyPI rejected upload because of unknown classifiers.
Should have caught this in 1.18.1, but I think I messed that one up by building from the wrong branch

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #220 (27cc973) into master (77072dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files           9        9           
  Lines        1014     1014           
  Branches      163      163           
=======================================
  Hits          967      967           
  Misses         43       43           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77072dc...27cc973. Read the comment docs.

Copy link
Owner

@jquast jquast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic

@jquast
Copy link
Owner

jquast commented Sep 20, 2021

sorry for delay had an especially busy day, are you going to release to pypi, also?

@avylove avylove merged commit bf0ef30 into master Sep 21, 2021
@avylove avylove deleted the Fix-metadata-formatting branch September 21, 2021 01:19
@avylove
Copy link
Collaborator Author

avylove commented Sep 21, 2021

Yeah, I'll push the release out if I don't run into any other blockers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants