SourceKittenFramework: largely port library loading for Windows #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
This adds Windows specific handling for dynamic symbol resolution into a library. The `dlopen` and `dlsym` APIs are not portable as they are part of POSIX rather than the C standard. Use the Windows equivalents of `LoadLibraryW` and `GetProcAddress`. TODO: this requires further refinement to detect the Swift toolchain installation.
jpsim
reviewed
Jun 14, 2023
jpsim
reviewed
Jun 15, 2023
jpsim
reviewed
Jun 15, 2023
jpsim
reviewed
Jun 15, 2023
Co-authored-by: JP Simard <jp@jpsim.com>
compnerd
commented
Jun 15, 2023
I’m fine if you do this as a follow-up. |
|
Yeah, I think that we should address that as a follow up. The current plan to change the install location means that this path is going to need to be dynamic. |
jpsim
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Windows specific handling for dynamic symbol resolution into a library. The
dlopenanddlsymAPIs are not portable as they are part of POSIX rather than the C standard. Use the Windows equivalents ofLoadLibraryWandGetProcAddress.TODO: this requires further refinement to detect the Swift toolchain installation.