feat: add support for node 12 and node 13#38
Open
jrmclaurin wants to merge 1 commit intojprichardson:masterfrom
Open
feat: add support for node 12 and node 13#38jrmclaurin wants to merge 1 commit intojprichardson:masterfrom
jrmclaurin wants to merge 1 commit intojprichardson:masterfrom
Conversation
refactor: port from nan to node-addon-api BREAKING CHANGE: drop support node 7 and below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of kexec from nan to node-addon-api, which cleans up the code and provides support for node versions up to the latest (currently node 13). Migrating from nan to node-addon-api removes support for node 7 and below, so this would need to be released as a breaking change.
This PR also cleans up error handling by checking of the return values of all system calls, and throwing JS exceptions with information about any system call failures.
Not sure if this is the direction you want to take the project, but I wanted to offer the contribution in case you feel that migrating to node-addon-api is the right call.