Skip to content

[WIP] Fix compilation errors and warnings for Node.js 12.#37

Open
benjamn wants to merge 3 commits intojprichardson:masterfrom
meteor:update-for-node-12
Open

[WIP] Fix compilation errors and warnings for Node.js 12.#37
benjamn wants to merge 3 commits intojprichardson:masterfrom
meteor:update-for-node-12

Conversation

@benjamn
Copy link

@benjamn benjamn commented May 9, 2019

Closes #36.

@benjamn benjamn changed the title Fix compilation errors and warnings for Node.js 12. [WIP] Fix compilation errors and warnings for Node.js 12. May 9, 2019
@benjamn
Copy link
Author

benjamn commented May 9, 2019

@jprichardson How committed are you to continuing to support Node 0.12? I ask because that's the only Node version that's still failing. I think I know how to fix it, but the solution would clutter the code with more preprocessor macros.

@pnathan
Copy link

pnathan commented Dec 18, 2019

It would be cool if this could be merged, or the package taken over. It's been almost half a year.... kexec itself last got updated in 2016. :-/

@jprichardson
Copy link
Owner

@pnathan tests are failing. Happy for someone to step up and help maintain.

@pnathan
Copy link

pnathan commented Dec 20, 2019

@jprichardson I'm not a node expert - I'm happy to dedicate some time to fix this in the next few weeks, if you're up for gesturing vaguely at probable directions of error.

@laverdet
Copy link

@benjamn nan provides wrappers for the invocations that are failing. If I'm reading the travis error log correctly you would just need to swap out Nan::Get, Nan::Set, and Nan::GetFunction.

@laverdet
Copy link

You can also swap out the Utf8Value wrapper with Nan::Utf8String.

@i-am-al-x
Copy link

Here is a workaround that uses the Meteor rewrite, "kexec v4.0.0".
https://stackoverflow.com/questions/70884111/fix-kexec-error-failure-problem-broken-that-prevents-unable-to-npm-inst/70884112#70884112
Of course, we would prefer that the rewrite gets pulled into the Master branch, but until then, I documented this workaround, which allowed me to use "npm install" so I could get WebPack working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build on node 12

5 participants