Skip to content

Conversation

@tpickett
Copy link
Contributor

By using a 'request' object, we are able to set various options about the request including specifying a proxy to be used with the request.

@jprichardson
Copy link
Owner

Thanks. But this causes the tests to fail. Please fix so tests don't fail.

@tpickett
Copy link
Contributor Author

i just saw that and am working on fixing the tests now.

@tpickett
Copy link
Contributor Author

I have it passing tests locally... but i can't get it to pass through TravisCI... any suggestions?

@tpickett
Copy link
Contributor Author

wow that was weird... only a minute ago I saw the console output and the pull request both said the build failed... Maybe I checked on the last commit build... Disregard it not passing in TravisCI.

@tpickett tpickett closed this Oct 21, 2014
@tpickett tpickett reopened this Oct 21, 2014
jprichardson added a commit that referenced this pull request Oct 23, 2014
Add Option to set a proxy
@jprichardson jprichardson merged commit 52cc93f into jprichardson:master Oct 23, 2014
@jprichardson
Copy link
Owner

Published.

On Tue, Oct 21, 2014 at 9:52 AM, Griffith T. Pickett <
notifications@github.com> wrote:

Reopened #16 #16.


Reply to this email directly or view it on GitHub
#16 (comment).

Simple & Secure Bitcoin Wallet: https://www.coinbolt.com
Bitcoin / JavaScript: http://cryptocoinjs.com
Follow me on Twitter: http://twitter.com/jprichardson

@jprichardson
Copy link
Owner

Thanks again :)

On Thu, Oct 23, 2014 at 10:55 AM, JP Richardson jprichardson@gmail.com
wrote:

Published.

On Tue, Oct 21, 2014 at 9:52 AM, Griffith T. Pickett <
notifications@github.com> wrote:

Reopened #16 #16.


Reply to this email directly or view it on GitHub
#16 (comment).

Simple & Secure Bitcoin Wallet: https://www.coinbolt.com
Bitcoin / JavaScript: http://cryptocoinjs.com
Follow me on Twitter: http://twitter.com/jprichardson

Simple & Secure Bitcoin Wallet: https://www.coinbolt.com
Bitcoin / JavaScript: http://cryptocoinjs.com
Follow me on Twitter: http://twitter.com/jprichardson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants