[BREAKING] moveSync: refactor to use renameSync

[manidlou]

fix #608.

Refactored moveSync to be consistent with move. Also removed unnecessary rimraf package from dev-deps.

[coveralls]

Coverage decreased (-0.2%) to 86.019% when pulling 95a9c72 on fix-move-sync into fe516c3 on v8-dev.

[manidlou]

@RyanZim I was thinking maybe that'd better we follow your good pattern of creating v8-dev branch and include this one (I will update the PR base branch) as well as #587 to v8 release. Also, I will have more PRs to do some cleanups 😁 tho. So we can include them all to v8 release?

[manidlou]

I changed the base to v8-dev.

[JPeer264]

Could not think of any addition. Also nice cleanups in the tests 👏

[RyanZim]

Code LGTM

[RyanZim]

This will need rebased to fix merge conflicts.

@manidlou you've been very helpful here at fs-extra, and too often, I feel like I'm the bottleneck with the release process. As a result, I've added you to fs-extra on npm (i.e. you now have npm publish rights). Of course, as always, we still should get peer review before merging our own PRs. If you have any questions, or need any help with getting a release out, I'm always here, can ask me questions on GH or write me at opensrc@ryanzim.com, whichever you prefer.

[manidlou]

@RyanZim thanks a lot for giving me publish rights. I am truly honored to be part of fs-extra team! I also appreciate your openness for offering help. Just to confirm with you, when I run npm owner ls fs-extra, it only returns you and @jprichardson. IDK if it should include me as well or there is another way of checking this?!

You are right about the conflict. I'll rebase this.

[manidlou]

Rebased!

[RyanZim]

@manidlou Sorry, seems npm was a little buggy and didn't give you access when I requested it. Now fixed; you should have access.

[manidlou]

Thanks @RyanZim I appreciate it!

[manidlou]

@jprichardson are you ok with this?! So that I can merge this since move*() still needs some work. I am gonna apply another fix to move*() to handle same paths correctly. But this needs to be merged before that one comes in! 😁

[jprichardson]

@manidlou yep, I'm okay with it