Conversation
manidlou
reviewed
Nov 9, 2017
Collaborator
manidlou
left a comment
manidlou
left a comment
There was a problem hiding this comment.
This is good @RyanZim! But, you mean we don't need to check if we have a filter opt at all? I mean calling Promise.resolve without checking whether we need to call it or not, wouldn't affect the perf for the cases that we don't have a filter opt?!
Collaborator
Author
|
@manidlou Good point about the perf; wouldn't have much impact if we're just calling a noop function, but with the extra |
RyanZim
force-pushed
the
async-filter
branch
from
f2c043d to
9732252
Compare
Collaborator
Author
|
Updated & fixed merge conflicts. |
Repository owner
deleted a comment from
coveralls
Nov 14, 2017
ghost
mentioned this pull request
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.