Add native fs.copyFile and fs.copyFileSync to copy() and copySync()#505
Merged
jprichardson merged 2 commits intodevelopfrom Nov 7, 2017
Merged
Add native fs.copyFile and fs.copyFileSync to copy() and copySync()#505jprichardson merged 2 commits intodevelopfrom
jprichardson merged 2 commits intodevelopfrom
Conversation
Collaborator
Author
|
IDK what the problem is with travis! @jprichardson @RyanZim do you know what the issue is with travis? |
Collaborator
|
Restarted the build and it worked! |
RyanZim
approved these changes
Oct 31, 2017
Collaborator
RyanZim
left a comment
RyanZim
left a comment
There was a problem hiding this comment.
LGTM; tested locally on Node 8 and ensured that the native method is indeed being used in environments that support it without issues.
…nction to util/utimes.js
manidlou
changed the title
manidlou
changed the title
RyanZim
approved these changes
Nov 1, 2017
Collaborator
Author
|
@jprichardson ping?! |
Owner
|
Looks good. Should be bundled in next major along with |
This was referenced Dec 12, 2017
Merged
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #490.
This is based against the
developbranch.Added native
fs.copyFileandfs.copyFileSynctocopy()andcopySync().