Cannot copy/move 'X' to a subdirectory of itself, 'Y'.

[steve02081504]

my repo on windows somehow not work and gets errors like this:
Cannot copy 'C:\Users\STEVE0~1\AppData\Local\Temp\fount_import_1756277197196\fount.json' to a subdirectory of itself, 'C:\Users\steve02081504\workstation\fount\data\users\steve02081504\chars\disco_ball\fount.json'.

hope it can be fixed :)

[steve02081504]

this bug not happen in 11.2.0 but happens in 11.3.0 and 11.3.1

[RyanZim]

Is this copy or copySync? What parameters are you calling the copy function with when you get this error?

[steve02081504]

Is this copy or copySync? What parameters are you calling the copy function with when you get this error?

I use copy+remove when I try to avoid move's bug (it didnt work) and move, heres the code:

import { existsSync } from 'node:fs'
import { mkdir, rm, stat, readdir } from 'node:fs/promises'
import { tmpdir } from 'node:os'
import path from 'node:path'
import url from 'node:url'

import { move, remove } from 'npm:fs-extra@11.2.0'

import { exec } from '../../../scripts/exec.mjs'
import { loadJsonFile } from '../../../scripts/json_loader.mjs'
import { loadPart } from '../../../server/managers/index.mjs'
import { isPartLoaded } from '../../../server/parts_loader.mjs'

import { cloneRepo } from './git.mjs'
import { getAvailablePath } from './path.mjs'
import { isFountPart, unzipDirectory } from './zip.mjs'


async function moveWithMerge(src, dest) {
	if (!existsSync(dest)) return await move(src, dest)

	const srcStat = await stat(src)
	const destStat = await stat(dest)

	// Source is a file
	if (srcStat.isFile())
		if (destStat.isFile())
			await move(src, dest, { overwrite: true })
		else
			throw new Error(`Cannot move file to directory: ${dest}`)
	// Source is a directory
	else if (srcStat.isDirectory())
		if (destStat.isDirectory())
			await mergeDirectories(src, dest)
		else
			throw new Error(`Cannot move directory to file: ${dest}`)
}

async function mergeDirectories(srcDir, destDir) {
	const items = await readdir(srcDir)
	for (const item of items) {
		const srcPath = path.join(srcDir, item)
		const destPath = path.join(destDir, item)
		const srcStat = await stat(srcPath)

		if (srcStat.isFile())
			await move(srcPath, destPath, { overwrite: true })
		else if (srcStat.isDirectory())
			if (!existsSync(destPath))
				await move(srcPath, destPath)
			else
				await mergeDirectories(srcPath, destPath)
	}
	await remove(srcDir)
}

async function ImportAsData(username, data) {
	if (!await isFountPart(data)) throw new Error('Invalid fount part: no fount.json found')
	const tempDir = path.join(tmpdir(), 'fount_import_' + Date.now())
	await mkdir(tempDir, { recursive: true })
	try {
		await unzipDirectory(data, tempDir)
	} catch (err) {
		console.error('Unzip failed:', err)
		await rm(tempDir, { recursive: true, force: true })
		throw new Error(`Unzip failed: ${err.stack || err}`)
	}
	try {
		const metaPath = path.join(tempDir, 'fount.json')
		/**
		 * @type {{type: string, dirname: string, data_files: string[]}}
		 */
		const meta = await loadJsonFile(metaPath)
		const needsReload = isPartLoaded(username, meta.type, meta.dirname)
		const targetPath = await getAvailablePath(username, meta.type, meta.dirname)
		meta.data_files ??= []
		if (existsSync(targetPath)) {
			const files = await readdir(targetPath)
			for (const file of files)
				if (!meta.data_files.includes(file))
					await rm(path.join(targetPath, file), { recursive: true, force: true })
		}
		await moveWithMerge(tempDir, targetPath)
		if (needsReload)
			loadPart(username, meta.type, meta.dirname)
		else
			import(url.pathToFileURL(path.join(targetPath, 'main.mjs'))).catch(x => x)
	} catch (err) {
		rm(tempDir, { recursive: true, force: true }).catch(x => x)
		throw new Error(`loadMeta failed: ${err.message || err}`)
	}
}

[cderv]

If it can help, this happens to us in a project that is using vite-plugin-copy-sync@0.13.1, which has deps to "fs-extra": "^11.1.0" in its package.json

Error message is

[vite-plugin-static-copy:build] Cannot copy 'D:\a\quarto-cli\quarto-cli\src\webui\quarto-preview\dist\quarto-preview.js' to a subdirectory of itself, 'D:\a\quarto-cli\quarto-cli\src\resources\preview\quarto-preview.js'.
[vite-plugin-static-copy] Copy count was not set.
error during build:
Error: Cannot copy 'D:\a\quarto-cli\quarto-cli\src\webui\quarto-preview\dist\quarto-preview.js' to a subdirectory of itself, 'D:\a\quarto-cli\quarto-cli\src\resources\preview\quarto-preview.js'.
    at Object.checkParentPaths (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/fs-extra@11.3.1/node_modules/fs-extra/lib/util/stat.js:109:11)
    at eventLoopTick (ext:core/01_core.js:175:7)
    at async Object.copy (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/fs-extra@11.3.1/node_modules/fs-extra/lib/copy/copy.js:29:3)
    at async copyAll (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/vite-plugin-static-copy@0.13.1/node_modules/vite-plugin-static-copy/dist/index.js:530:7)
    at async Object.writeBundle (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/vite-plugin-static-copy@0.13.1/node_modules/vite-plugin-static-copy/dist/index.js:942:19)
    at async Promise.all (index 0)
    at async PluginDriver.hookParallel (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/rollup@2.79.1/node_modules/rollup/dist/es/shared/rollup.js:22676:9)
    at async file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/rollup@2.79.1/node_modules/rollup/dist/es/shared/rollup.js:23804:13
    at async catchUnfinishedHookActions (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/rollup@2.79.1/node_modules/rollup/dist/es/shared/rollup.js:23126:20)
    at async doBuild (file:///D:/a/quarto-cli/quarto-cli/src/webui/quarto-preview/node_modules/.deno/vite@3.2.6/node_modules/vite/dist/node/chunks/dep-1889fec9.js:45792:22)

So they do this

var copyAll = async (rootSrc, rootDest, targets, flatten) => {
  const copyTargets = await collectCopyTargets(rootSrc, targets, flatten);
  for (const copyTarget of copyTargets) {
    const { src, dest, transform, preserveTimestamps, dereference } = copyTarget;
    const resolvedSrc = path.resolve(rootSrc, src);
    const resolvedDest = path.resolve(rootSrc, rootDest, dest);
    const transformOption = resolveTransformOption(transform);
    if (transformOption) {
      await transformCopy(transformOption, resolvedSrc, resolvedDest);
    } else {
      await fs.copy(resolvedSrc, resolvedDest, {
        preserveTimestamps,
        dereference
      });
    }
  }
  return copyTargets.length;
};

I managed to solve it on my end for now by pinning a previous version, and I'll update anyway all the version soon (as we are outdated). Hopefully this will solve things for me.

However, maybe it can help sharing this to confirm is this is expected or not based on logs I got from GHA.

If it is not, feel free to ignore.

[steve02081504]

@cderv ya can use "fs-extra": "11.2.0" to fix this, see steve02081504/fount@55d5945 :)

[RyanZim]

@steve02081504 Are you running in Node.js, or is this deno or some other runtime?

[RyanZim]

@cderv ^11.1.0 is a version range that could be satisfied by several versions of fs-extra. What precise version were you running when you encountered this error? (check package-lock.json or run npm ls fs-extra for npm; yarn.lock or yarn why fs-extra for yarn) And what exact version did you pin to in order to fix?

I'm trying to figure out if you're dealing with the same issue as the OP

[steve02081504]

@steve02081504 Are you running in Node.js, or is this deno or some other runtime?

ye my repo is running on deno

[RyanZim]

@steve02081504 fs-extra is designed for, and exclusively tested on, Node.js. I'm not really familiar with the intricacies of deno, and it's not something we officially support.

You state that v11.2.0 is working, but v11.3.0 doesn't work, which is puzzling, as the only significant change to copy between those versions was #1028, and there were no changes to move between those versions.

[steve02081504]

@steve02081504 fs-extra is designed for, and exclusively tested on, Node.js. I'm not really familiar with the intricacies of deno, and it's not something we officially support.

guess I can help for build an deno CI pr if ya need it?

You state that v11.2.0 is working, but v11.3.0 doesn't work, which is puzzling, as the only significant change to copy between those versions was #1028, and there were no changes to move between those versions.

okey got it, ive opend denoland/deno#30570 for let deno team knows this :D

[cderv]

@RyanZim This only happened in my CI environment and with a Deno project. So maybe this is was related to the environment and filesystem there. I would need to connect on CI environment to retrieve the information. I just know that pinning down the version seemed to solved it. I fixed my old build by adding to my package.json

"fs-extra": "<=11.3.0"

The problematic version for me was 11.3.1, but could be some conflicts with other deno stuff 🤷‍♂️

We are now using npm for this specific build, so everything is good on my side for now.

[Tango992]

This is a bug from the Deno side and only happens on Windows (ref: denoland/deno#30570 (comment)). The current workaround is to use versions prior to 11.3.1, and note that the areIdentical function will always return false on Deno.