Remove 0.37 deprecation warnings #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,7 @@ var assign = require('object-assign') | |||
| var path = require('path') | |||
| var BrowserWindow = require('browser-window') | |||
| var wargs = require('./args') | |||
| var v = (process.versions.electron || '').split('.').map(Number) | |||
There was a problem hiding this comment.
This could be a good place for the new assignment magic in ES2015:
let [major, minor, patch] = process.versions.electron.split('.').map(Number)There was a problem hiding this comment.
Yes, absolutely! But here the code is supposed to be backwards compatible and the tests are currently run with mocha in node (so we'd have to enable --harmony_destructuring or use babel).
Besides, I would hope that these version checks can be removed soon anyway, seeing how fast Electron is moving along.
|
ACK. Although, I think it's fine to support just the latest until Electron becomes stable. i.e the maintenance of legacy Electron code may not be worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes deprecation warnings in 0.37
Since the tests run outside of Electron I'm just defaulting to an empty version string to make sure the tests don't fail.