Enable loading multiple --require-main scripts #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the artificial constraint put on
--require-main
which previously would only load the given script if only one--require-main
argument is given.This behaviour is confusing because it would do nothing when providing two scripts via
--require-main
and misleading at best. In contrast, the--require
argument allows for multiple scripts to be provided.The rationale behind loading multiple scripts is to preload Babel or TypeScript transpilers to be able to run modern JavaScript as preload scripts.
In my case, I use one script for the main electron process in order to turn off logging to file for the tested components (I use
electron-log
) and in the renderer process I do preload Chai extensions and configure Enzyme.