Skip to content

Conversation

@damienleroux
Copy link
Contributor

Hi,

This changes is breaking. People will have to install their own version of node-cache.

Thank you

@damienleroux
Copy link
Contributor Author

Tests are Ok

nodeCacheModule Tests
    √ Getting absent key should return null
    √ Setting then getting key should return value
    √ Setting then deleting then getting key should return null
    √ Setting several keys then calling .flush() should remove all keys
    √ Setting several keys then calling .mget() should retrieve all keys
    √ Setting several keys via .mset() then calling .mget() should retrieve all keys
    √ Using background refresh should reset a nearly expired key (1517ms)


  7 passing (2s)

@jpodwys
Copy link
Owner

jpodwys commented May 24, 2018

Thank you for this! I think I was too vague when I suggested the tests run against the latest version of node cache. I meant the dev dep should be to "4.x" rather than "latest" :)

@damienleroux
Copy link
Contributor Author

updated :)

@jpodwys jpodwys merged commit 92db69a into jpodwys:master May 24, 2018
@jpodwys
Copy link
Owner

jpodwys commented May 24, 2018

Published to npm as 2.0.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants