This repository was archived by the owner on Jul 17, 2023. It is now read-only.
fix: restore preferred StatsBarStyle onOrientationChanged #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
reviewed
Oct 31, 2018
src/statusbar_ios.mm
Outdated
| if (keyWindow) | ||
| setPreferredStatusBarStyle(keyWindow, style); | ||
|
|
||
| QTimer* timer = new QTimer(); |
There was a problem hiding this comment.
The timer object is not deleted => memory leak. Allocating it on the stack would be an option, but QTimer has also a
handy static singleShot() method to make this more straight-forward:
QTimer::singleShot(200, []() {
...
});
There was a problem hiding this comment.
thx explaining. using singleShot it's much easier now.
learning new things every day ;-)
|
Awesome, thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have tested with some devices and simulator and now the preferred style remains if orientation changes.
simply setting the style again doesn't help
setting the opposite theme and starting a QTimer to set to preferred style again works.