feat: allow omitting <generator> via generator: false - #251
Merged
Conversation
The generator field previously only accepted a string and always fell back to the library URL, so there was no way to remove the <generator> element from the output. Passing a falsy value such as false leaked into the XML as <generator>false</generator> in RSS, or was ignored in Atom. Widen FeedOptions.generator to string | false and skip emitting the element entirely when it is false, for both RSS 2.0 and Atom 1.0. The default and custom-string behaviour is unchanged. Covered by unit tests for both formats.
jpmonette
approved these changes
Jul 5, 2026
Owner
|
ty @mmilanovic4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
generatoronly accepts a string and always falls back to thelibrary URL, so there's no way to remove the element. Passing
falseleaks into RSS output as false and issilently ignored in Atom.
This widens FeedOptions.generator to
string | falseand skips theelement entirely when
false, for both RSS 2.0 and Atom 1.0. Default andcustom-string behaviour is unchanged; existing snapshots pass untouched.
Added unit tests covering default / custom / omitted cases for both formats.
Closes #250