Skip to content

Update JplayerRtmp.as - #161

Closed
iking0980 wants to merge 1 commit into
jplayer:masterfrom
iking0980:patch-1
Closed

Update JplayerRtmp.as#161
iking0980 wants to merge 1 commit into
jplayer:masterfrom
iking0980:patch-1

Conversation

@iking0980

Copy link
Copy Markdown
Contributor

Fix problem with connection Amazon cloudfront signeture url

Fix problem with connection Amazon cloudfront signeture url
@happyworm

Copy link
Copy Markdown
Contributor

The RTMP part was @rmhall baby.
Could you eyeball this PR Robert and give a nod if it should be merged.

Ideally if you or @iking0980 could provide an example RTMP url for an Amazon cloudfront signature... Then I/we can review and test it.

@happyworm

Copy link
Copy Markdown
Contributor

Nit pick away. I always add the curlies too 👍
It is one of the recommended coding styles for Open Source projects.

Thank you for the feedback @rmhall - I plan to integrate this into the dev branch next.

@happyworm

Copy link
Copy Markdown
Contributor

While I'm in this part of the code... I also noticed this:

if (rtmpSrc.indexOf(".mp3") != -1) {
   appName = rtmpSrc.substring(endHost,rtmpSrc.indexOf("mp3:"));

Shouldn't they both be "mp3:" @rmhall?
BTW, this code was not part of the PR commit.

@happyworm

Copy link
Copy Markdown
Contributor

Code merged into the dev branch.

Release note:
[dev] Added Support: The Flash RTMP player now supports an Amazon CloudFront Signature URL. This addition was proposed here Update JplayerRtmp.as by iking0980.

Cheers to all involved in this change.

@happyworm happyworm closed this Nov 3, 2013
@thepag

thepag commented Nov 12, 2014

Copy link
Copy Markdown
Contributor

Hello @iking0980 would you please sign our CLA

Cheers!

@thepag

thepag commented Nov 19, 2014

Copy link
Copy Markdown
Contributor

Hello @iking0980
Please sign the CLA

If you do not want to sign it, then please contact me and we can remove your contribution from the project.

@thepag

thepag commented Nov 19, 2014

Copy link
Copy Markdown
Contributor

Cheers @iking0980

@thedumbtechguy

Copy link
Copy Markdown

I don't think this fix worked. Still can't play when the urls are signed.

RTMP is horribly broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants