More similarity metrics #1396
Draft
More similarity metrics #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
reviewed
Nov 28, 2023
SimDing
reviewed
Dec 11, 2023
|
|
||
| public enum SimilarityMetric implements ToDoubleFunction<JPlagComparison> { | ||
| AVG("average similarity", JPlagComparison::similarity), | ||
| MIN("minimum similarity", JPlagComparison::minimalSimilarity), | ||
| MAX("maximal similarity", JPlagComparison::maximalSimilarity), | ||
| INTERSECTION("matched tokens", it -> (double) it.getNumberOfMatchedTokens()); | ||
| INTERSECTION("matched tokens", it -> (double) it.getNumberOfMatchedTokens()), | ||
| SYMMETRIC("symmetric similarity", it -> { |
There was a problem hiding this comment.
Isn't this equivalent to the implementation of the "average similarity", only ignoring base code?
|
With reversing the distribution, it now is the wrong way for the report-viewer. We should decide whether we want it to be reversed in the application and then written into the report the way the report-viewer currently expects it, or whether the report-viewer should turn it around |
tsaglam
added
enhancement
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the similarity metrics described in #1134
Also changes the report generation to export all metrics defined in the enum
As discussed the distributions in the report are not reversed anymore, this is an api breaking change.