Bump to Go 1.21 by jpillora · Pull Request #440 · jpillora/chisel

jpillora · 2023-08-13T13:16:42Z

Bump deps
Bump go
Key file/gen (thanks @cmenginnz)

Co-authored-by: Jaime Pillora <dev@jpillora.com>

…to go120

jpillora · 2023-08-13T13:56:54Z

Can you plz review @cmenginnz ?

jpillora · 2023-08-13T13:57:34Z

client/client.go

 	}
 	//set default log level
-	client.Logger.Info = c.Verbose
+	client.Logger.Info = true


im reverting this, users who want to silence chisel can >/dev/null

jpillora · 2023-08-13T14:28:24Z

I’m thinking of switching keygenfile to use plain base 64, because PEM encoding is multi line and adds an extra step when passing it inline. I’m thinking ck-<n base64 chars> which would also make it easier to identify its inline - rather than a file path

cmenginnz

LGTM

cmenginnz · 2023-08-13T23:08:05Z

I’m thinking of switching keygenfile to use plain base 64, because PEM encoding is multi line and adds an extra step when passing it inline. I’m thinking ck-<n base64 chars> which would also make it easier to identify its inline - rather than a file path

The ssh.ParsePrivateKey(key) function actually supports RSA (PKCS#1), PKCS#8, DSA (OpenSSL), and ECDSA private keys. If we use a private file format here, we will lose the support of these algorithms and the existing tools such as openssl.
Please let me know your decision and I'm willing to continue patching for it.

jpillora · 2023-08-15T11:14:41Z

I think we'd want the key parser to support both PEM and chisel-key format (ck-<163-base64-chars> drop the 2 equals)

cmenginnz · 2023-08-16T05:11:28Z

@jpillora I made a PR(#441) to go121 branch that implements:

--genkey generates a key file in CK format
--keyfile accepts:
2.1 a file in CK format
2.2 a file in PEM formet
2.3 an inline key in CK format

jpillora · 2023-08-19T01:04:10Z

It took a while, but its in! Thanks for your help @cmenginnz 😄

jpillora · 2023-08-19T01:06:08Z

v1.9.0 releasing now https://github.com/jpillora/chisel/actions/runs/5908510975

* Set ServerName (SNI) to *hostname. Useful for spoofing our way through restrictive gateways. * Bump actions/checkout from 2 to 3.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added --sni switch to control the ServerName when connecting with TLS. Makes 'domain fronting' possible. * feat: dependabot workflow automation for updating dependency Signed-off-by: Pratik Raj <rajpratik71@gmail.com> * Bump github.com/fsnotify/fsnotify from 1.4.9 to 1.6.0 (jpillora#389) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * UDP buffer size override with CHISEL_UDP_MAX_SIZE environment variable (jpillora#367) * Add locking around the connection count to fix a data race. (jpillora#342) Co-authored-by: andres-portainer <andres-portainer@users.noreply.github.com> * fix: small typo error in main.go (jpillora#334) * Respond to /health and /version by request path rather than by the whole url string (jpillora#328) Co-authored-by: bar <foo@example.org> * Update version.go (jpillora#288) * Providing chisel's client with a logger level (jpillora#281) Co-authored-by: Barak Sharoni <barak.sharoni@velocity.tech> Co-authored-by: barak-sharoni-velocity <81081183+barak-sharoni-velocity@users.noreply.github.com> * add EnvBool * Fix jpillora#390: Use code to generate certificates for client & server (jpillora#400) * docker alpine->google-distroless * docker to use scratch * Fix missing NetDialContext: c.config.DialContext (jpillora#398) * actions: setup go v3 * switch to scratch image * update dependabot * move chisel to flyio * Bump to Go 1.21 (jpillora#440) Co-authored-by: cmeng <cmenginnz@gmail.com> * add arm v5 builds (jpillora#395) * Sync with upstream --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pratik Raj <rajpratik71@gmail.com> Co-authored-by: ip-rw <s@ip.rw> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pratik Raj <Rajpratik71@gmail.com> Co-authored-by: Jaime Pillora <jpillora@gmail.com> Co-authored-by: fsiegmund <siegmund@slb.com> Co-authored-by: andres-portainer <91705312+andres-portainer@users.noreply.github.com> Co-authored-by: andres-portainer <andres-portainer@users.noreply.github.com> Co-authored-by: 0xflotus <0xflotus@gmail.com> Co-authored-by: BigSully <BigSully@users.noreply.github.com> Co-authored-by: bar <foo@example.org> Co-authored-by: invist <35263248+c-f@users.noreply.github.com> Co-authored-by: zuzgon <zuzgon@gmail.com> Co-authored-by: Barak Sharoni <barak.sharoni@velocity.tech> Co-authored-by: barak-sharoni-velocity <81081183+barak-sharoni-velocity@users.noreply.github.com> Co-authored-by: Jaime Pillora <dev@jpillora.com> Co-authored-by: Guillaume SMAHA <GuillaumeSmaha@users.noreply.github.com> Co-authored-by: cmeng <cmenginnz@gmail.com> Co-authored-by: maurerr <maurerr@users.noreply.github.com>

Co-authored-by: cmeng <cmenginnz@gmail.com>

@testwill

* Set ServerName (SNI) to *hostname. Useful for spoofing our way through restrictive gateways. * Bump actions/checkout from 2 to 3.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added --sni switch to control the ServerName when connecting with TLS. Makes 'domain fronting' possible. * feat: dependabot workflow automation for updating dependency Signed-off-by: Pratik Raj <rajpratik71@gmail.com> * Bump github.com/fsnotify/fsnotify from 1.4.9 to 1.6.0 (jpillora#389) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * UDP buffer size override with CHISEL_UDP_MAX_SIZE environment variable (jpillora#367) * Add locking around the connection count to fix a data race. (jpillora#342) Co-authored-by: andres-portainer <andres-portainer@users.noreply.github.com> * fix: small typo error in main.go (jpillora#334) * Respond to /health and /version by request path rather than by the whole url string (jpillora#328) Co-authored-by: bar <foo@example.org> * Update version.go (jpillora#288) * Providing chisel's client with a logger level (jpillora#281) Co-authored-by: Barak Sharoni <barak.sharoni@velocity.tech> Co-authored-by: barak-sharoni-velocity <81081183+barak-sharoni-velocity@users.noreply.github.com> * add EnvBool * Fix jpillora#390: Use code to generate certificates for client & server (jpillora#400) * docker alpine->google-distroless * docker to use scratch * Fix missing NetDialContext: c.config.DialContext (jpillora#398) * actions: setup go v3 * switch to scratch image * update dependabot * move chisel to flyio * Bump to Go 1.21 (jpillora#440) Co-authored-by: cmeng <cmenginnz@gmail.com> * add arm v5 builds (jpillora#395) * chore: remove refs to deprecated io/ioutil (jpillora#459) thanks @testwill * Bump golang.org/x/crypto from 0.12.0 to 0.16.0 (jpillora#473) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/sync from 0.3.0 to 0.5.0 (jpillora#472) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-go from 3 to 5 (jpillora#484) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump to Go 1.22. Add `.rpm` `.deb` and `.akp` to releases. Fix bad version comparison. * fix chisel version in docker image (closes jpillora#228) * always test with latest stable binaries are already released with latest goreleaser, docker image uses alpine:go, both are latest stable go, so makes sense to always test with latest stable too * SLB mods and garble releaser * Use latest garble --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pratik Raj <rajpratik71@gmail.com> Co-authored-by: ip-rw <s@ip.rw> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pratik Raj <Rajpratik71@gmail.com> Co-authored-by: Jaime Pillora <jpillora@gmail.com> Co-authored-by: fsiegmund <siegmund@slb.com> Co-authored-by: andres-portainer <91705312+andres-portainer@users.noreply.github.com> Co-authored-by: andres-portainer <andres-portainer@users.noreply.github.com> Co-authored-by: 0xflotus <0xflotus@gmail.com> Co-authored-by: BigSully <BigSully@users.noreply.github.com> Co-authored-by: bar <foo@example.org> Co-authored-by: invist <35263248+c-f@users.noreply.github.com> Co-authored-by: zuzgon <zuzgon@gmail.com> Co-authored-by: Barak Sharoni <barak.sharoni@velocity.tech> Co-authored-by: barak-sharoni-velocity <81081183+barak-sharoni-velocity@users.noreply.github.com> Co-authored-by: Jaime Pillora <dev@jpillora.com> Co-authored-by: Guillaume SMAHA <GuillaumeSmaha@users.noreply.github.com> Co-authored-by: cmeng <cmenginnz@gmail.com> Co-authored-by: maurerr <maurerr@users.noreply.github.com> Co-authored-by: guangwu <guoguangwu@magic-shield.com> Co-authored-by: Leon Verrall <lverrall@slb.com>

cmenginnz and others added 12 commits May 16, 2023 10:25

generate deterministic key with a given seed

85a7d96

allow users to specify a private key file

234a8f6

update help text for private-key-file

5afbbec

Co-authored-by: Jaime Pillora <dev@jpillora.com>

test

0c6de47

Merge remote-tracking branch 'cmenginnz/deterministic_private_key' in…

f6f0ba9

…to go120

fix fingerprint tests for Go 1.20 or later

a0dc819

undo some previous changes

c54555e

copy GenerateKey function of Go 1.19 as GenerateKeyGo119

16ebfe0

add keygen arg to genreate an ssh private key file

a6d82b2

Merge remote-tracking branch 'cmenginnz/deterministic_private_key' in…

498c801

…to go120

bump to go1.21

522b9e3

allow inline keyfile, more help, regen README

d86f477

jpillora commented Aug 13, 2023

View reviewed changes

cmenginnz approved these changes Aug 13, 2023

View reviewed changes

cmenginnz and others added 2 commits August 19, 2023 10:49

add supports for chisel-key format (#441)

346065a

changelog

123844c

jpillora merged commit 69093be into master Aug 19, 2023

jpillora deleted the go121 branch August 19, 2023 01:00

WaysonWei mentioned this pull request Mar 18, 2024

bump chisel version to 1.90 portainer/portainer#11416

Closed

NewtonMan pushed a commit to OutSystems/chisel that referenced this pull request Oct 16, 2024

Bump to Go 1.21 (jpillora#440)

e261010

Co-authored-by: cmeng <cmenginnz@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to Go 1.21#440

Bump to Go 1.21#440
jpillora merged 14 commits intomasterfrom
go121

jpillora commented Aug 13, 2023 •

edited

Loading

Uh oh!

jpillora commented Aug 13, 2023

Uh oh!

jpillora Aug 13, 2023

Uh oh!

jpillora commented Aug 13, 2023

Uh oh!

cmenginnz left a comment

Uh oh!

cmenginnz commented Aug 13, 2023

Uh oh!

jpillora commented Aug 15, 2023

Uh oh!

cmenginnz commented Aug 16, 2023

Uh oh!

jpillora commented Aug 19, 2023

Uh oh!

jpillora commented Aug 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jpillora commented Aug 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpillora commented Aug 13, 2023

Uh oh!

jpillora Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

jpillora commented Aug 13, 2023

Uh oh!

cmenginnz left a comment

Choose a reason for hiding this comment

Uh oh!

cmenginnz commented Aug 13, 2023

Uh oh!

jpillora commented Aug 15, 2023

Uh oh!

cmenginnz commented Aug 16, 2023

Uh oh!

jpillora commented Aug 19, 2023

Uh oh!

jpillora commented Aug 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpillora commented Aug 13, 2023 •

edited

Loading