Code simplification, removed duplication #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin helped me a lot (thanks!), however I noticed most of the code was being repeated so I spent 15 minutes trying to simplify it. It seems to be working correctly, currency sorting works fine & fast on a table with 500 rows (built using a JS array).
Reduced from 47 lines to 32 lines.
You could probably even reduce it further like so:
This gets it down to 28 lines, but it's fairly trivial.