Add a global player visibility that can override player choice.#520
Open
HydrolienF wants to merge 1 commit intojpenilla:masterfrom
Open
Add a global player visibility that can override player choice.#520HydrolienF wants to merge 1 commit intojpenilla:masterfrom
HydrolienF wants to merge 1 commit intojpenilla:masterfrom
Conversation
It's map.player-visibility and it can be set to "FORCED_HIDDEN", "FORCED_SHOWN", "PLAYER_SETTING". Player can still do `/map hide` or `/map show`, but if the player visibility is set to FORCED_HIDDEN, no player will be visible or if it is set to FORCED_SHOWN, all player will be visible. It does not make spectator or NPC visible, it only affect player that would be visible if `/map show` was executed.
Author
|
I've tested it. It does hide all players with |
Author
|
Let me know if you would like to see any changes to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's done with
map.player-visibilityin the config and it can be set to "FORCED_HIDDEN", "FORCED_SHOWN", "PLAYER_SETTING". Player can still do/map hideor/map show, but if the player visibility is set to FORCED_HIDDEN, no player will be visible or if it is set to FORCED_SHOWN, all player will be visible. It does not make spectator or NPC visible, it only affect player that would be visible if/map showwas executed.It will close #209
I've tried to fit to the coding style of the project & to place the new enum at the most logic location. Let me know if you would prefer any changes.
I will switch from draft to pull request once I will have done more tests.
I can also add this new config param to the config wiki page.