Skip to content

Remove support for argument values beginning with an unquoted forward slash #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2019

Conversation

jpdillingham
Copy link
Owner

Somewhat related to #55; this change fixes some erroneous behavior when using multiple arguments with the forward slash delimiter.

/a /b should result in two boolean arguments a and b, but instead would result in one string argument a with value /b. This PR corrects this behavior.

This is a breaking change requiring that argument values beginning with a forward slash be quoted (e.g. /file /input.txt must now be /file '/input.txt').

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #58    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           1      1            
  Lines         370    183   -187     
======================================
- Hits          370    183   -187
Impacted Files Coverage Δ
src/Utility.CommandLine.Arguments/Arguments.cs 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ff61e...64f42ff. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant